[PATCH] D113633: [llvm] Add support for DW_TAG_immutable_type
Paul Robinson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 12 10:10:23 PST 2021
probinson added a comment.
In D113633#3127799 <https://reviews.llvm.org/D113633#3127799>, @ljmf00 wrote:
> Also, take the example of https://reviews.llvm.org/D113634 , which may be split into two patches for further discussion. Anyway, I tend to agree with you, I can join everything together in D113634 <https://reviews.llvm.org/D113634>.
Usually (not always, but usually) related patches are split by subproject. So, lldb changes go in one patch, llvm in another patch, clang in another patch. Exceptions occur when patches are very closely related or actually interdependent. I don't think adding immutable_type falls into that category. So, please keep the lldb and llvm patches separate.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113633/new/
https://reviews.llvm.org/D113633
More information about the llvm-commits
mailing list