[PATCH] D102437: [LV] NFC: Decouple foldTailByMasking from isScalarWithPredication.

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 08:57:24 PST 2021


david-arm accepted this revision.
david-arm added a comment.
This revision is now accepted and ready to land.

LGTM! I think this is a sensible refactor and it seems clearer in the code now what's going on.



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:5251
+    Instruction *I, bool VFIterationIsPredicated) const {
+  // If no predication is used, no predicatation is needed for the widened op.
+  if (!Legal->blockNeedsPredication(I->getParent()) && !VFIterationIsPredicated)
----------------
nit: predication


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102437/new/

https://reviews.llvm.org/D102437



More information about the llvm-commits mailing list