[PATCH] D113766: [fir] Add fir.gentypedesc conversion
Kiran Chandramohan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 12 07:58:58 PST 2021
kiranchandramohan added inline comments.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:653
+/// Lower `fir.gentypedesc` to a global constant.
+struct GenTypeDescOpConversion : public FIROpConversion<fir::GenTypeDescOp> {
----------------
Nit: Can you add a bit more documentation on the conversion (global + addressof) and why is it a global (when it was not in FIR).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113766/new/
https://reviews.llvm.org/D113766
More information about the llvm-commits
mailing list