[PATCH] D113769: [fir] !fir.tdesc type conversion

[Kiran Chandramohan via Phabricator via llvm-commits]

kiranchandramohan added a comment.

Nit: Although these are all converted to i8 pointers, it might be good to have a few more tests? I have given a few below.

$ ./bin/fir-opt --fir-to-llvm-ir tdesc.mlir

> module  {
>
>   llvm.func @foo1(!llvm.ptr<i8>) attributes {sym_visibility = "private"}
>   llvm.func @foo2(!llvm.ptr<i8>) attributes {sym_visibility = "private"}
>   llvm.func @foo3(!llvm.ptr<i8>) attributes {sym_visibility = "private"}
>
> }

$ cat tdesc.mlir

> func private @foo1(%arg : !fir.tdesc<!fir.array<100xf32>>)
> func private @foo2(%arg : !fir.tdesc<f32>)
> func private @foo3(%arg : !fir.tdesc<!fir.type<derived7{f1:f32,f2:f32}>>)




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113769/new/

https://reviews.llvm.org/D113769