[PATCH] D113739: [X86][ABI] Change the alignment of f80 in 32-bit calling conversion to meet with different data layout

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.

> Is there a bugzilla PR covering this?

Probability not. I guess few people concerns 32-bit darwin now. I didn't mean to fix the bug. We just have the same requirment in our downstream code.



================
Comment at: llvm/test/CodeGen/X86/inline-asm-fpstack.ll:2
 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
 ; RUN: llc < %s -mcpu=generic -mtriple=i386-apple-darwin -verify-machineinstrs -no-integrated-as | FileCheck %s
 
----------------
RKSimon wrote:
> So maybe add a i386-linux-unknown test?
I tried. Then I found the check doubled due to darwin and Linux have different inline asm comment. More importantly, the interesting info is buried by the large diff.
On the other hand, we have lots of lit tests involves f80 load/store. We have confidence given they are not changed :)
```
$ grep -r -E 'fldt|fstpt' llvm/test/CodeGen/X86/ | wc -l
994
$ grep -r -E 'fldt|fstpt' llvm/test/CodeGen/X86/ |cut -d ':' -f 1 |uniq | wc -l
58
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113739/new/

https://reviews.llvm.org/D113739