[PATCH] D113002: TableGen: sort SearchableTable emission order by fields, not top-level name

[Alexandros Lamprineas via Phabricator via llvm-commits]

labrinea added a comment.

Looks good. Thanks for fixing this inconsistency. Can you remove the obsolete CHECK lines and replace two more occurences of {{PRLAR[0]?_EL2}} in the tests?



================
Comment at: llvm/test/MC/AArch64/armv8r-sysreg.s:313-316
+# CHECK-NEXT: 	mrs	x0, PRBAR0_EL1          // encoding: [0x00,0x68,0x38,0xd5]
+# CHECK-NEXT: 	mrs	x0, PRBAR0_EL2          // encoding: [0x00,0x68,0x3c,0xd5]
+# CHECK-NEXT: 	mrs	x0, PRLAR0_EL1          // encoding: [0x20,0x68,0x38,0xd5]
+# CHECK-NEXT: 	mrs	x0, PRLAR0_EL2          // encoding: [0x20,0x68,0x3c,0xd5]
----------------
obsolete


================
Comment at: llvm/test/MC/AArch64/armv8r-sysreg.s:365
 # CHECK-NEXT: 	mrs	x0, PRBAR15_EL2         // encoding: [0x80,0x6f,0x3c,0xd5]
 # CHECK-NEXT: 	mrs	x0, {{PRLAR[0]?_EL2}}   // encoding: [0x20,0x68,0x3c,0xd5]
 # CHECK-NEXT: 	mrs	x0, PRLAR1_EL2          // encoding: [0xa0,0x68,0x3c,0xd5]
----------------
PRLAR0_EL2 ?


================
Comment at: llvm/test/MC/AArch64/armv8r-sysreg.s:388-391
+# CHECK-NEXT: 	mrs	x30, PRBAR0_EL1         // encoding: [0x1e,0x68,0x38,0xd5]
+# CHECK-NEXT: 	mrs	x30, PRBAR0_EL2         // encoding: [0x1e,0x68,0x3c,0xd5]
+# CHECK-NEXT: 	mrs	x30, PRLAR0_EL1         // encoding: [0x3e,0x68,0x38,0xd5]
+# CHECK-NEXT: 	mrs	x30, PRLAR0_EL2         // encoding: [0x3e,0x68,0x3c,0xd5]
----------------
obsolete


================
Comment at: llvm/test/MC/AArch64/armv8r-sysreg.s:440
 # CHECK-NEXT: 	mrs	x30, PRBAR15_EL2        // encoding: [0x9e,0x6f,0x3c,0xd5]
 # CHECK-NEXT: 	mrs	x30, {{PRLAR[0]?_EL2}}  // encoding: [0x3e,0x68,0x3c,0xd5]
 # CHECK-NEXT: 	mrs	x30, PRLAR1_EL2         // encoding: [0xbe,0x68,0x3c,0xd5]
----------------
PRLAR0_EL2 ?


================
Comment at: llvm/test/MC/AArch64/armv8r-sysreg.s:463-466
+# CHECK-NEXT: 	msr	PRBAR0_EL1, x0          // encoding: [0x00,0x68,0x18,0xd5]
+# CHECK-NEXT: 	msr	PRBAR0_EL2, x0          // encoding: [0x00,0x68,0x1c,0xd5]
+# CHECK-NEXT: 	msr	PRLAR0_EL1, x0          // encoding: [0x20,0x68,0x18,0xd5]
+# CHECK-NEXT: 	msr	PRLAR0_EL2, x0          // encoding: [0x20,0x68,0x1c,0xd5]
----------------
obsolete


================
Comment at: llvm/test/MC/AArch64/armv8r-sysreg.s:538-541
+# CHECK-NEXT: 	msr	PRBAR0_EL1, x30         // encoding: [0x1e,0x68,0x18,0xd5]
+# CHECK-NEXT: 	msr	PRBAR0_EL2, x30         // encoding: [0x1e,0x68,0x1c,0xd5]
+# CHECK-NEXT: 	msr	PRLAR0_EL1, x30         // encoding: [0x3e,0x68,0x18,0xd5]
+# CHECK-NEXT: 	msr	PRLAR0_EL2, x30         // encoding: [0x3e,0x68,0x1c,0xd5]
----------------
obsolete


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113002/new/

https://reviews.llvm.org/D113002