[PATCH] D113666: [flang][CodeGen] Transform `fir.emboxchar` to a sequence of LLVM MLIR

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

Don't forget to sync back to fir-dev. Especially when you make lots of changes (auto, variable names) otherwise it's gonna become a nightmare to track.



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1403
+    mlir::ValueRange operands = adaptor.getOperands();
+    MLIRContext *ctx = emboxChar.getContext();
+
----------------
This is often `auto` in MLIR code base. 


================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:1408
+
+    mlir::Location loc = emboxChar.getLoc();
+    mlir::Type llvmStructTy = convertType(emboxChar.getType());
----------------
`getLoc()` is almost 100% of the time `auto` in the LLVM/MLIR code base. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113666/new/

https://reviews.llvm.org/D113666