[PATCH] D113678: [TypePromotion] Extend TypePromotion::isSafeWrap

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 12 01:23:25 PST 2021


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Good bit of brain exercise for the morning... Nice addition and cleanup too, thanks. Just a couple of function renaming requests from me.



================
Comment at: llvm/test/CodeGen/AArch64/typepromotion-overflow.ll:176
 
 define i32 @unsafe_sub_underflow(i8 zeroext %a) {
 ; CHECK-LABEL: unsafe_sub_underflow:
----------------
Good to change the function name before committing, same for the other altered test.


================
Comment at: llvm/test/Transforms/TypePromotion/ARM/wrapping.ll:103
 
 define i32 @unsafe_add_underflow(i8 zeroext %a) {
 ; CHECK-LABEL: @unsafe_add_underflow(
----------------
And in this file too :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113678/new/

https://reviews.llvm.org/D113678



More information about the llvm-commits mailing list