[PATCH] D113465: [llvm-dwarfdump][Statistics] Handle LTO cases with cross CU referencing
Djordje Todorovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 12 00:29:07 PST 2021
djtodoro added a comment.
Some extra nits included. I'll take another look into the functionality itself.
================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/LTO_CCU_zero_loc_cov.ll:13-29
+; Source files:
+;main.c:
+;extern int sum(int a, int b);
+;
+;int main()
+;{
+; int a = 10, b = 5;
----------------
All these should also start with double ';;'
================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/LTO_CCU_zero_loc_cov.ll:63
+ %10 = load i32, i32* %4, align 4, !dbg !16
+ call void @llvm.dbg.value(metadata i32 undef, metadata !23, metadata !DIExpression()), !dbg !36 ; Hard coded line: There was %10 instead of undef.
+ call void @llvm.dbg.value(metadata i32 2, metadata !29, metadata !DIExpression()), !dbg !36
----------------
The comment as well should also start with double ';;'
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113465/new/
https://reviews.llvm.org/D113465
More information about the llvm-commits
mailing list