[PATCH] D113733: [llvm-objdump/mac] Add support for new load commands

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/obj2yaml/MachO/raw-linkedit.yaml:6-7
+# RUN: yaml2obj %s > %t
+# RUN: llvm-objdump -p %t | FileCheck %s --check-prefix=CHECK-OBJDUMP
+# RUN: llvm-otool -l %t | FileCheck %s --check-prefix=CHECK-OBJDUMP
 #
----------------
Somebody else might see things differently, but I'm not sure adding llvm-objdump testing to an obj2yaml test is the right thing to do. You need testing in llvm/test/tools/llvm-objdump for the new output. If there's no existing load-command testing there, I'd add something that uses yaml2obj to generate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113733/new/

https://reviews.llvm.org/D113733