[PATCH] D113573: Add a (nonfunctional) -dyld_info flag to llvm-objdump.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/MachO/dyld_info.test:6-7
+#      CHECK:{{.*}}bind.macho-x86_64:
+CHECK:dyld information:
+CHECK:[not yet implemented].
----------------
Consider also CHECK-NEXT, for full clarity (not needed for test explicitness, thanks to --strict-whitespace, but might make it easier to follow what is the exact output for those not looking at the FileCheck command line).


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:1184
+static void PrintDyldInfo(MachOObjectFile *O) {
+  outs() << "dyld information:" << '\n';
+  outs() << "[not yet implemented].\n";
----------------



================
Comment at: llvm/tools/llvm-objdump/ObjdumpOpts.td:300-301
+def dyld_info : Flag<["--"], "dyld_info">,
+      HelpText<"Print bind and rebase information used by dyld to resolve "
+               "external references in a final linked binary.">,
+      Group<grp_mach_o>;
----------------
1) Other Mach-O specific options state something like "(requires --macho)" in their help text.
2) Other options don't look to have a trailing full stop.


================
Comment at: llvm/tools/llvm-objdump/OtoolOpts.td:44
 // -m don't use archive(member) syntax
-// -dyld_info
 // -dyld_opcodes
----------------
You're removing this option from the list of llvm-otool unsupported options, but as I understand it, you've added the option to llvm-objdump, but not llvm-otool. I'm not sure that's quite right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113573/new/

https://reviews.llvm.org/D113573