[PATCH] D113736: [DebugInfo][Try 2] Only create concrete DIEs of concrete functions

Ellis Hoag via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 23:28:04 PST 2021


ellis created this revision.
Herald added a subscriber: hiraditya.
ellis added a reviewer: dblaikie.
ellis added a project: debug-info.
ellis published this revision for review.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

At the begining of the module we can iterate through the functions to
see which SPs should have concrete DIEs. Then when we need to reference
a DIE for a SP we can decide if it's ok to create a concrete DIE or not.

Fixes

- https://bugs.llvm.org/show_bug.cgi?id=52159
- https://bugs.llvm.org/show_bug.cgi?id=30637

This was previously landed in https://reviews.llvm.org/D112337 but was
reverted because of a memory bug. This patch fixes that bug by making
sure we don't reference abstract origins from another CU.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D113736

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfDebug.h
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfUnit.h
  llvm/test/DebugInfo/Generic/import-inlined-declaration.ll
  llvm/test/DebugInfo/Generic/inlined-local-type.ll
  llvm/test/DebugInfo/Generic/inlined-static-var.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113736.386739.patch
Type: text/x-patch
Size: 22963 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211112/6456b898/attachment-0001.bin>


More information about the llvm-commits mailing list