[PATCH] D112312: [DSE] Add OR_None (not for commit)

Evgeniy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 20:44:49 PST 2021


ebrevnov added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp:1012
+      if (AAR == AliasResult::NoAlias)
+        return OW_None;
       return OW_Unknown;
----------------
fhahn wrote:
> nikic wrote:
> > Maybe move this check to the start?
> I originally had the check just after getting `AAR`, but `isOverwrite` considers out-of-bounds writes killing other writes to the same underlying object, which would be missed by the early exit.
Could you clarify which particular piece of code handles "out-of-bounds" case?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112312/new/

https://reviews.llvm.org/D112312



More information about the llvm-commits mailing list