[PATCH] D113160: [stack-safety] Check SCEV constraints at memory instructions.

Florian Mayer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 19:29:02 PST 2021


fmayer added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:257
+  const SCEV *typeSizeToSCEV(TypeSize TS);
+  bool isSafeAccess(const Use &UI, AllocaInst *AI, const Instruction *I,
+                    const SCEV *AccessSize);
----------------
kstoimenov wrote:
> If this is an output param, please consider moving it to the end of the argument list. 
There is no output parameter in this. This is just non-const because getSCEV does not take const.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113160/new/

https://reviews.llvm.org/D113160



More information about the llvm-commits mailing list