[PATCH] D113702: [lld-macho] Fix symbol relocs handling for compact unwind's functionAddress

Thu Nov 11 17:03:10 PST 2021

int3 added inline comments.

================
Comment at: lld/test/MachO/weak-definition-gc.s:262
+## This was generated from compiling weak-sub-lsda.s above at rev a2404f11c77e
+## and then running it through `ld -r`. This converts a number of unwind-related
+## relocations from section- to symbol-based ones.
----------------
int3 wrote:
> oontvoo wrote:
> > at this point is it worth implementing -r yet?
> > these yaml files are kind of annoying
> I mean, feel free to attempt it :P it's not a priority for me
also, it's not clear to me that implementing `-r` would remove the need for these YAML files, unless we want to reproduce all the quirks of ld64. We might very well find it easier to not convert section to symbol relocations in our own implementation.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113702/new/

https://reviews.llvm.org/D113702