[PATCH] D113702: [lld-macho] Fix symbol relocs handling for compact unwind's functionAddress

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:930
+        // Skip if it is e.g. a weak def that didn't prevail.
+        if (sym->getFile() != this) {
+          ++it;
----------------
oontvoo wrote:
> sorry, not 100% related to this, but  if the same input file is repeated on the command line, does the pointer equality hold true? or do they count as separate files?
> 
separate files (there's a dup symbol test along those lines)


================
Comment at: lld/test/MachO/weak-definition-gc.s:262
+## This was generated from compiling weak-sub-lsda.s above at rev a2404f11c77e
+## and then running it through `ld -r`. This converts a number of unwind-related
+## relocations from section- to symbol-based ones.
----------------
oontvoo wrote:
> at this point is it worth implementing -r yet?
> these yaml files are kind of annoying
I mean, feel free to attempt it :P it's not a priority for me


================
Comment at: lld/test/MachO/weak-definition-gc.s:473-481
+    - EH_Frame1
+    - func.eh
+    - ''
+    - ''
+    - ''
+    - ''
+    - ''
----------------
oontvoo wrote:
> do we need all these?
looks like the empty strings can be deleted yeah. the other two are symbol names


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113702/new/

https://reviews.llvm.org/D113702