[PATCH] D113167: [lld-macho]Allow exporting weak_def_can_be_hidden(AKA "autohide") symbols

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 16:58:46 PST 2021


oontvoo updated this revision to Diff 386690.
oontvoo added a comment.

- re-arrange the condition a bit.
- also parallelize scanning the symbol tables in export/unexport-ing. This shows a small improvment in our internal apps:

x ./LLD_no_parallel.txt
+ ./LLD_with_parallel.txt
+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+

| +                                                                                                                                     x                               |
| +++   +++  +      +   +                                                                                          x                     x    x  x             x  x xxx |
|                                                                                                                                                                       | _____MA______ |  | ________________A________M______ |
|

+---------------------------------------------------------------------------------------------------------------------------------------------------------------------+

  N           Min           Max        Median           Avg        Stddev

x  10         84.01         89.41         88.64        87.693     1.7424061
+  10          71.9         74.29         72.63        72.753    0.77734663
Difference at 95.0% confidence
	-14.94 +/- 1.26763
	-17.0367% +/- 1.44553%
	(Student's t, pooled s = 1.34912)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113167/new/

https://reviews.llvm.org/D113167

Files:
  lld/MachO/ConcatOutputSection.cpp
  lld/MachO/Driver.cpp
  lld/MachO/InputFiles.cpp
  lld/MachO/SymbolTable.cpp
  lld/MachO/SymbolTable.h
  lld/MachO/Symbols.h
  lld/test/MachO/export-options.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113167.386690.patch
Type: text/x-patch
Size: 10459 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211112/bdd6d01a/attachment.bin>


More information about the llvm-commits mailing list