[PATCH] D113721: [lld-macho] Fix symbol relocs handling for LSDAs

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo accepted this revision.
oontvoo added a comment.
This revision is now accepted and ready to land.

LG Thanks!!!



================
Comment at: lld/MachO/UnwindInfoSection.cpp:442-443
         break;
-      if (lsda1->referent.get<InputSection *>() !=
-          lsda2->referent.get<InputSection *>())
         break;
----------------
Thank you!!! was wondering why our build was crashing at this line today.

``` assert.h assertion failed at llvm/include/llvm/ADT/PointerUnion.h:159 in T llvm::PointerUnion<lld::macho::Symbol *, lld::macho::InputSection *>::get() const [PTs = <lld::macho::Symbol *, lld::macho::InputSection *>, T = lld::macho::InputSection *]: is<T>() && "Invalid accessor called"```


================
Comment at: lld/test/MachO/compact-unwind-sym-relocs.s:246-250
+    - ''
+    - ''
+    - ''
+    - ''
+    - ''
----------------
dont need these?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113721/new/

https://reviews.llvm.org/D113721