[PATCH] D113651: [DebugInfo] DwarfCompileUnit: Check for existing global vars after getting a context

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 16:21:48 PST 2021


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Ah, looks like the comment was never accurate (& was copy/pasted from various other handling, which is more likely to be accurate in the other places (like types, rather than variables)) when introduced in f6b936bc062e7490cfe956d58d47ba92b46e830f

Mixed feelings about possible implications of making a (albeit NFCI) code change to match a comment rather than changing the comment to match the code. But to make this case consistent with the other cases the comment was copy/pasted from, sure let's go with this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113651/new/

https://reviews.llvm.org/D113651



More information about the llvm-commits mailing list