[PATCH] D106585: Fix clang debug info irgen of i128 enums

Thu Nov 11 15:45:11 PST 2021

glandium added a comment.

In D106585#3125280 <https://reviews.llvm.org/D106585#3125280>, @rnk wrote:

> In D106585#3122726 <https://reviews.llvm.org/D106585#3122726>, @glandium wrote:
>
>> It seems to have been fixed in rG3c47c5ca13b8a502de3272e8105548715947b7a8 <https://reviews.llvm.org/rG3c47c5ca13b8a502de3272e8105548715947b7a8>.
>
> Are you sure you've arrived at the right code review? This change, D106585 <https://reviews.llvm.org/D106585>, modified type information, which is unrelated to the change you linked to. We have also noticed *other* determinism issues (follow up with @hans to learn more), but they aren't related to this change, which is from July.

Yes, cherry-picking rG3c47c5ca13b8a502de3272e8105548715947b7a8 <https://reviews.llvm.org/rG3c47c5ca13b8a502de3272e8105548715947b7a8>, rGbadcd585897253e94b7b2d4e6f9f430a2020d642 <https://reviews.llvm.org/rGbadcd585897253e94b7b2d4e6f9f430a2020d642> and reverting the changes to clang/lib/CodeGen/CGDebugInfo.cpp from rG323049329939becf690adbeeff9f5f7e219075ec <https://reviews.llvm.org/rG323049329939becf690adbeeff9f5f7e219075ec> and rGf9f56488e02d1c09a9cd4acde61ce1c712e71405 <https://reviews.llvm.org/rGf9f56488e02d1c09a9cd4acde61ce1c712e71405> fixes the non-determinism in Firefox with clang 13.0.0.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106585/new/

https://reviews.llvm.org/D106585