[PATCH] D113610: [cmake] Add option LLVM_ENABLE_VISIBILITY_MACROS

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 13:47:14 PST 2021


rnk added subscribers: MaskRay, serge-sans-paille, compnerd.
rnk added a comment.

+ at tstellar @serge-sans-paille for the recent LLVM_EXTERNAL_VISIBILITY changes
+ at compnerd @maskray for our discussions about the shared library build

I think there is a valid use case for a static, fully hidden visibility build of LLVM. I don't think this is the absolute cleanest way to support that use case, but it works and I can live with it.

Part of me wants to say that we should make these visibility macros conditional on the existing LLVM_ENABLE_DYLIB (sp?) option. If the user is statically linking LLVM, we should drop these annotations and allow the global visibility preset to take precedence.



================
Comment at: llvm/include/llvm/Config/llvm-config.h.cmake:95
 /* Define to 1 if you have the <sysexits.h> header file. */
 #cmakedefine HAVE_SYSEXITS_H ${HAVE_SYSEXITS_H}
 
----------------
Unrelated, but this isn't namespaced, and it should not live in the llvm-config header... I'll try to blame that and chase it down... Looks like it is D88467


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113610/new/

https://reviews.llvm.org/D113610



More information about the llvm-commits mailing list