[PATCH] D113652: [DebugInfo][test] Simplify/imporove a few tests using --impicit-check-not=DW_TAG. NFC

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 13:27:54 PST 2021


dblaikie added inline comments.


================
Comment at: llvm/test/DebugInfo/X86/align_c11.ll:27-33
+; CHECK:   DW_TAG_base_type
+; CHECK:   DW_TAG_array_type
+; CHECK:     DW_TAG_subrange_type
+; CHECK:   DW_TAG_base_type
+; CHECK:   DW_TAG_subprogram
+; CHECK:     DW_TAG_variable
+; CHECK:   DW_TAG_base_type
----------------
Perhaps this test could avoid testing all these other DW_TAGs by using --name or some other filtering on the dump, so it only dumps the relevant DIEs?


================
Comment at: llvm/test/DebugInfo/X86/align_cpp11.ll:81-84
+; CHECK:   DW_TAG_pointer_type
+; CHECK:   DW_TAG_base_type
+; CHECK:   DW_TAG_pointer_type
+; CHECK:   DW_TAG_const_type
----------------
Any chance some filtering could be done to avoid checking a bunch of other tags in this test? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113652/new/

https://reviews.llvm.org/D113652



More information about the llvm-commits mailing list