[PATCH] D113541: [lld-macho] Fix trailing slash in oso_prefix
Jez Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 11 12:20:39 PST 2021
int3 accepted this revision.
int3 added a comment.
lgtm
================
Comment at: lld/MachO/Driver.cpp:1160-1162
+ if (config->osoPrefix.equals("."))
+ expanded += sep;
+ else if (config->osoPrefix.endswith(sep))
----------------
thevinster wrote:
> We can simplify this with a `||` in the first if? Could we also document the behavior of `real_path` here (that it removes the trailing slash)?
+1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113541/new/
https://reviews.llvm.org/D113541
More information about the llvm-commits
mailing list