[PATCH] D113703: [RISCV] Reduce duplicate FP test cases.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D113703#3125391 <https://reviews.llvm.org/D113703#3125391>, @jrtc27 wrote:

> Hm, I'd expect all the tests that call @llvm.foo to be in -instrinsics.ll given that's what they are; -arith.ll just isn't a great name, because all of this is basically arithmetic.



In D113703#3125391 <https://reviews.llvm.org/D113703#3125391>, @jrtc27 wrote:

> Hm, I'd expect all the tests that call @llvm.foo to be in -instrinsics.ll given that's what they are; -arith.ll just isn't a great name, because all of this is basically arithmetic.

I forgot to mention that *-arith.ll has the tests for all the fma flavors. *-intrinsics.ll only has the basic test. The -arith.ll files also have this comment at the top "These tests are each targeted at a particular RISC-V FPU instruction. Most other files in this folder exercise LLVM IR instructions that don't directly match a RISC-V instruction.". Though that's not strictly true since conversion instructions are in different files already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113703/new/

https://reviews.llvm.org/D113703