[PATCH] D111447: [Dexter] Add DexDeclareAddress command and address function

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer updated this revision to Diff 386587.
StephenTozer added a comment.

Move the generation of the address resolution map to Heuristic (`None` initialized on command objects until the heuristic runs). Added address information to the verbose output (only prints additional info if `DexDeclareAddress` is actually present), and always print the name of the address in the "missing values" and "encountered expected values" output (implementation for misordered values is more complex, and has been ignored). Also, removed some unused functions in DexExpectWatchBase.

Adds a test for the penalty of a missing address, and also a test for all the aforementioned printing behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111447/new/

https://reviews.llvm.org/D111447

Files:
  cross-project-tests/debuginfo-tests/dexter/Commands.md
  cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py
  cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexDeclareAddress.py
  cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexExpectWatchBase.py
  cross-project-tests/debuginfo-tests/dexter/dex/heuristic/Heuristic.py
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/penalty/missing_dex_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/address_after_ref.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/expression_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/identical_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/multiple_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/offset_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/self_comparison.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/address_printing.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/err_duplicate_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/err_undeclared_addr.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111447.386587.patch
Type: text/x-patch
Size: 29395 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211111/5bb65ae6/attachment.bin>