[PATCH] D113653: [NVPTX][AsmPrinter] Avoid removing globals before calling AsmPrinter::doFinalization()

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

LGTM in general.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXAsmPrinter.h:310
+
+  // Do not allow base AsmPrinter doing something with globals.
+  void emitGlobalVariable(const GlobalVariable *GV) override {}
----------------
asavonic wrote:
> Can we keep the original comment to explain the problem? Something like:
> ```Do not allow base AsmPrinter doing something with globals: global variables are emitted at the beginning and base AsmPrinter will attempt to do that again in doFinalization().```
+1.  We do need a good explanation why we're doing something as odd as not emitting globals.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113653/new/

https://reviews.llvm.org/D113653