[PATCH] D113644: [NFC][InlineAdvisor] Inform advisor when the module is invalidated

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 10:07:19 PST 2021


mtrofin added a comment.

In D113644#3125023 <https://reviews.llvm.org/D113644#3125023>, @aeubanks wrote:

> are you actually seeing compile time improvements with this patch?

yes. significant

> if nothing has been invalidated, then `FunctionPropertiesAnalysis` is still cached, and the recalculation would be negligible since we're just iterating through each function in the module and getting a cached int for each one and summing them together, which is basically free

that cache retrieval is what's not free, when the scale is large.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113644/new/

https://reviews.llvm.org/D113644



More information about the llvm-commits mailing list