[PATCH] D113395: [flang][CodeGen] Transform `IsPresentOpConversion` and `AbsentOpConversion`

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

In D113395#3124789 <https://reviews.llvm.org/D113395#3124789>, @PeteSteinfeld wrote:

> I use the version of `clang-format` from llvm release 12, which is the latest released version.

https://llvm.org/
"4 October 2021: LLVM 13.0.0 is now available for download! "

Time for an update :)



================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:579
+    pattern
+        .insert<AbsentOpConversion, AddrOfOpConversion, CallOpConversion,
+                ExtractValueOpConversion, HasValueOpConversion,
----------------
schweitz wrote:
> clementval wrote:
> > awarzynski wrote:
> > > schweitz wrote:
> > > > Different version of clang-format?
> > > Not necessarily. IIRC, clang-format has no hard rules for where to break lines. But I couldn't find a definitive answer. 
> > > 
> > > I use clang-format-13. Pre-commit CI seems happy. Shall we leave it like this?
> > Looks fine now. 
> Looks like the random whitespace changes disappeared. Good.
> 
> Andrzej, we've found that using even slightly different builds of clang-format cause mysterious whitespace changes. It's not about any rule. It just happens.
>  different builds of clang-format cause mysterious whitespace changes. 

I wish that my sight allowed me to spot such discrepancies! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113395/new/

https://reviews.llvm.org/D113395