[PATCH] D86706: [LLD][PowerPC] Add a pc-rel based long branch thunk

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 08:24:05 PST 2021


NeHuang marked an inline comment as done.
NeHuang added inline comments.


================
Comment at: lld/ELF/Thunks.cpp:1114
+    return (s.stOther >> 5) > 1
+               ? (Thunk *)make<PPC64R12SetupStub>(s)
+               : (Thunk *)make<PPC64PCRelLongBranchThunk>(s, a);
----------------
MaskRay wrote:
> How is the new `PPC64PCRelLongBranchThunk` different from `PPC64R12SetupStub`? Why can't the two be unified?
They are identical. We will create a NFC patch to unify them. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86706/new/

https://reviews.llvm.org/D86706



More information about the llvm-commits mailing list