[PATCH] D112025: Intrinsic for checking floating point class

[Serge Pavlov via Phabricator via llvm-commits]

sepavloff added inline comments.


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:723
+
+def int_is_fpclass
+    : DefaultAttrsIntrinsic<[LLVMScalarOrSameVectorWidth<0, llvm_i1_ty>],
----------------
arsenm wrote:
> The word "is" here reads weird to me, and you dropped it from the ISD node name. How about just llvm.fpclass? Also the description says "fclass"
I agree that this name is a bit awkward. Initially it was `llvm.fclass`, as you noticed, but then it was changed because:
- it is inconsistent with C function `fpclassify`, which also may get a special llvm intrinsic,
- `llvm.fclass` might be understood as if the intrinsic calculated the value class. Actually it only tests the value against the specified classes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112025/new/

https://reviews.llvm.org/D112025