[PATCH] D113662: [fir] Add placeholder conversion pattern for disptach operations

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

In D113662#3124234 <https://reviews.llvm.org/D113662#3124234>, @clementval wrote:

> I didn't really follow the fir.end discussion but my intuition is that `fir.end` is probably converted together with its parent operation.

That's not what I saw in my experiments. Perhaps that's what we should aim for or something that we still need to port from fir-dev? Time will tell!



================
Comment at: flang/test/Fir/convert-to-llvm-invalid.fir:26
+
+// expected-error at +1{{failed to legalize operation 'fir.dispatch_table'}}
+fir.dispatch_table @dispatch_tbl {
----------------
clementval wrote:
> awarzynski wrote:
> > How about a diagnostic check for `fir.dt_entry`?
> Not possible since `fir.dt_entry` cannot be standalone. 
See https://reviews.llvm.org/D113665 ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113662/new/

https://reviews.llvm.org/D113662