[PATCH] D111531: Fix minor deficiency in MachineSink.

[Markus Lavin via Phabricator via llvm-commits]

markus added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/MachineSink-implicit-x0.mir:1
+# RUN: llc -mtriple=riscv32 %s -run-pass=machine-sink -o - | FileCheck %s
+
----------------
StephenTozer wrote:
> Also just to add, does this need "-x mir"? I see some of the other `llc` tests on MIR files use it, but I don't know if it's actually required.
The majority of MIR tests depend on having `llc` detecting the input language from the filename extension and not using `-x mir` AFAICT.


================
Comment at: llvm/test/CodeGen/RISCV/MachineSink-implicit-x0.mir:35
+...
+---
----------------
StephenTozer wrote:
> I've just run the test, and it seems that this last line causes a parse error for llc; otherwise the test seems to work as written.
Hmm, what exactly are you running then? 
When I run
```
./bin/llvm-lit ../llvm/test/CodeGen/RISCV/MachineSink-implicit-x0.mir
```
it passes without issues.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111531/new/

https://reviews.llvm.org/D111531