[PATCH] D113295: [flang] Transform `fir.end` to an empty statement
Valentin Clement via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 11 04:46:46 PST 2021
clementval added inline comments.
================
Comment at: flang/lib/Optimizer/CodeGen/CodeGen.cpp:89
+ mlir::ConversionPatternRewriter &rewriter) const override {
+ rewriter.replaceOp(op, {});
+ return success();
----------------
mehdi_amini wrote:
> Nit: I think you can spell this `rewriter.eraseOp` for the same effect, but it expressed the intent a bit more clearly.
+1
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113295/new/
https://reviews.llvm.org/D113295
More information about the llvm-commits
mailing list