[PATCH] D111531: Fix minor deficiency in MachineSink.
Stephen Tozer via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 11 04:07:29 PST 2021
StephenTozer accepted this revision.
StephenTozer added a comment.
This revision is now accepted and ready to land.
Seems straightforward enough to me, the code block in question clearly only cares about preg defs for the purposes of sinking. LGTM, with one inline nit.
================
Comment at: llvm/test/CodeGen/RISCV/MachineSink-implicit-x0.mir:5
+# the implicit use of '$x0'.
+# Register '$x0' is a is a 'MRI->isConstantPhysReg()' on RISCV and such uses
+# should not inhibit sinking transformation even though they are livein to the
----------------
Remove double "is a".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111531/new/
https://reviews.llvm.org/D111531
More information about the llvm-commits
mailing list