[PATCH] D113658: [fir] Add !fir.len type conversion

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 02:22:19 PST 2021


kiranchandramohan accepted this revision.
kiranchandramohan added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Optimizer/CodeGen/TypeConverter.h:63
+    addConversion([&](fir::LenType field) {
+      return mlir::IntegerType::get(field.getContext(), 32);
+    });
----------------
Nit: A comment on why this is 32 bits while some others like character len is 64 or platform-dependent will be good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113658/new/

https://reviews.llvm.org/D113658



More information about the llvm-commits mailing list