[PATCH] D111447: [Dexter] Add DexDeclareAddress command and address function

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer updated this revision to Diff 386457.
StephenTozer added a comment.

Add a set of feature tests for DexDeclareAddress; also fix a minor error that would appear if the address was never resolved.

Before merging, I'm also going to add a bit more useful output to the test - in particular making the penalty cases more clear: if a declared address never resolves to a value this should be explicitly stated in the output (in verbose mode if not by default), and if a variable has a missing value that was an address (i.e. the variable is never seen holding the address value) then the user should see which address was missing, rather than just the resolved value of that address. This should come with a couple of new tests, and should also resolve Orlando's inline comment about the address resolutions map (as this will need to be referenced in a proper context object in order for this feature to work).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111447/new/

https://reviews.llvm.org/D111447

Files:
  cross-project-tests/debuginfo-tests/dexter/Commands.md
  cross-project-tests/debuginfo-tests/dexter/dex/command/ParseCommand.py
  cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexDeclareAddress.py
  cross-project-tests/debuginfo-tests/dexter/dex/command/commands/DexExpectWatchBase.py
  cross-project-tests/debuginfo-tests/dexter/dex/heuristic/Heuristic.py
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/address_after_ref.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/expression_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/identical_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/multiple_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/offset_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/commands/perfect/dex_declare_address/self_comparison.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/err_duplicate_address.cpp
  cross-project-tests/debuginfo-tests/dexter/feature_tests/subtools/test/err_undeclared_addr.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111447.386457.patch
Type: text/x-patch
Size: 24694 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211111/3c6ede0d/attachment.bin>