[PATCH] D113563: [fir] Add !fir.alloca conversion

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 11 01:40:04 PST 2021


rovka updated this revision to Diff 386446.
rovka added a comment.

Less auto.
Also replace TODO with error, although I'm not sure who should be generating the mem size function. If it's this pass, then TODO sounds better, but if it's supposed to already exist in the module by the time this pass runs then error is more appropriate. Maybe @schweitz or @jeanPerier can chime in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113563/new/

https://reviews.llvm.org/D113563

Files:
  flang/lib/Optimizer/CodeGen/CodeGen.cpp
  flang/lib/Optimizer/CodeGen/TypeConverter.h
  flang/lib/Optimizer/Dialect/FIROps.cpp
  flang/test/Fir/convert-to-llvm.fir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D113563.386446.patch
Type: text/x-patch
Size: 13498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211111/5d796aa1/attachment.bin>


More information about the llvm-commits mailing list