[PATCH] D113130: [llvm-libtool-darwin] Print a warning if object file names are repeated

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Some nits, but I haven't done a detailed review, and am leaving that to those actually invested in this tool.



================
Comment at: llvm/test/tools/llvm-libtool-darwin/archive-flattening.test:69
+# DUPLICATE-INPUT-DAG: [[PATHCORRECT]]
+# DUPLICATE-INPUT:     file '[[FILEB]]' was specified multiple times.
+# DUPLICATE-INPUT-DAG: [[PATHB]]
----------------
Missing warning: prefix.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/create-static-lib.test:66
+# RUN: llvm-as %S/Inputs/armv7-ios.ll -o %t/armv7/out.bc
+# # Command output should be empty.
+# RUN: llvm-libtool-darwin -static %t/arm64/out.bc %t/armv7/out.bc -o %t.lib 2>&1 | \
----------------



================
Comment at: llvm/tools/llvm-libtool-darwin/llvm-libtool-darwin.cpp:559-561
+        for (StringRef OriginalFile : MemberToFile.getValue()) {
+          ErrorStream << "in: " << OriginalFile.str() << '\n';
+        }
----------------
Nit: delete braces for single-line loop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113130/new/

https://reviews.llvm.org/D113130