[PATCH] D113601: [AArch64] Use custom lowering for {U,S}INT_TO_FP with i8.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1017
+    // operand to i16 for v8i8 and v16i8 (done by the custom lowering).
+    // Otherrwise promote the input to i32 first.
     setOperationPromotedToType(ISD::UINT_TO_FP, MVT::v4i8, MVT::v4i32);
----------------
dmgreen wrote:
> -> Otherwise
Thanks, the comment change is gone after moving to the existing if/else.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1043
     if (Subtarget->hasFullFP16()) {
       setOperationAction(ISD::SINT_TO_FP, MVT::v4i16, Custom);
       setOperationAction(ISD::UINT_TO_FP, MVT::v4i16, Custom);
----------------
dmgreen wrote:
> It might be worth combining into this if block, to keep the similar code together.
Good point, I moved it to the existing if/else in the committed version. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113601/new/

https://reviews.llvm.org/D113601