[PATCH] D113578: [SCEV] Apply loop guards when computing max BTC for arbitrary steps.

Thu Nov 11 00:25:06 PST 2021

nikic added a comment.

In D113578#3123701 <https://reviews.llvm.org/D113578#3123701>, @mkazantsev wrote:

> I'd rather move the assert inside of `applyLoopGuards`. If it breaks, it's a subject for improving our reasoning. I can imagine it could be breaking because of issues with caching (e.g. if addrecs are involved), though. So, unless the failures are mass and disruptive, I'd prefer it to stay and catch us opportunities.

We already know that the assertion is going to fail and also know why. See https://reviews.llvm.org/D102267#inline-967507 for two suggestions on how to avoid pessimization, or at least the known cases of it. This should either be addressed first, or the assert should be omitted.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113578/new/

https://reviews.llvm.org/D113578