[PATCH] D112411: [LNT] Updated cPerf to read the section Attributes (support Simpleperf)

Pavel Kosov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 22:56:08 PST 2021


kpdev42 added inline comments.


================
Comment at: lnt/testing/profile/cPerf.cpp:708-712
     // EXEC ELF objects aren't relocated. DYN ones are,
     // so if it's a DYN object adjust by subtracting the
     // map base.
-    bool IsSO = IsSharedObject(Maps[MapID].Filename);
-    uint64_t Adjust = IsSO ? Maps[MapID].Start : 0;
----------------
thopre wrote:
> Why is this no longer needed? You should adapt/remove the comment accordingly.
I've added a patch for it: https://reviews.llvm.org/D113648
Please review


Repository:
  rLNT LNT

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112411/new/

https://reviews.llvm.org/D112411



More information about the llvm-commits mailing list