[PATCH] D113552: [yaml2obj][XCOFF] parsing auxiliary symbols.

Xing GUO via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 18:59:35 PST 2021


Higuoxing added inline comments.


================
Comment at: llvm/lib/ObjectYAML/XCOFFEmitter.cpp:551-567
+        if (auto AS = dyn_cast<XCOFFYAML::CsectAuxEnt>(AuxSym.get()))
+          writeAuxSymbol(*AS);
+        else if (auto AS = dyn_cast<XCOFFYAML::FunctionAuxEnt>(AuxSym.get()))
+          writeAuxSymbol(*AS);
+        else if (auto AS = dyn_cast<XCOFFYAML::ExcpetionAuxEnt>(AuxSym.get()))
+          writeAuxSymbol(*AS);
+        else if (auto AS = dyn_cast<XCOFFYAML::FileAuxEnt>(AuxSym.get()))
----------------
It would be great to move these if-else statements into a helper function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113552/new/

https://reviews.llvm.org/D113552



More information about the llvm-commits mailing list