[PATCH] D113160: [stack-safety] Check SCEV constraints at memory instructions.

[Florian Mayer via Phabricator via llvm-commits]

fmayer added inline comments.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:401
         }
-        US.addRange(I,
-                    getAccessRange(UI, Ptr, DL.getTypeStoreSize(I->getType())));
+        auto TypeSize = DL.getTypeStoreSize(I->getType());
+        auto AccessRange = getAccessRange(UI, Ptr, TypeSize);
----------------
fmayer wrote:
> eugenis wrote:
> > move getTypeStoreSize into getTypeSize
> The way it is now makes it more obvious that this TypeSize is the same that we use in the `getAccessRange` call, so I'd prefer to leave it like this. WDYT?
I changed the name of getTypeSize to make more explicit what it does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113160/new/

https://reviews.llvm.org/D113160