[PATCH] D113582: [lld-macho] Support renaming of LSDA section

Vy Nguyen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 16:17:14 PST 2021


oontvoo accepted this revision.
oontvoo added a comment.
This revision is now accepted and ready to land.

LG



================
Comment at: lld/MachO/UnwindInfoSection.cpp:132
+  // in symbolsVec.
+  std::vector<CompactUnwindEntry<Ptr>> cuVector;
+  // Indices into the compact unwind vector.
----------------
int3 wrote:
> oontvoo wrote:
> > for consistency, can we stick to one naming convention? :) (hungarian notation or not?)
> > does `cuEntries`work?
> this is an existing name, but yes, happy to change it. cuEntries sounds good.
Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113582/new/

https://reviews.llvm.org/D113582



More information about the llvm-commits mailing list