[PATCH] D113615: [ELF] Make --no-relax disable R_X86_64_{,REX_}GOTPCRELX GOT optimization

Wed Nov 10 15:48:46 PST 2021

alexander-shaposhnikov added inline comments.

================
Comment at: lld/docs/ld.lld.1:348
 .It Fl -no-relax
-Disable target-specific relaxations. This is currently a no-op.
+Disable target-specific relaxations. This disables R_X86_64_GOTPCRELX and R_X86_64_REX_GOTPCRELX GOT optimization.
 .It Fl -no-rosegment
----------------
MaskRay wrote:
> alexander-shaposhnikov wrote:
> > I'd probably change the wording a  bit, either drop the second part ("This disables R_X86_64 ... ") or indicate that currently it works only for x86_64. I'm not really sure it's that useful, "Disable target-specific relaxations." seems to be sufficient and won't require frequent updates.
> This is a manpage where additional information can be useful. It's otherwise unclear `--no-relax` can help with R_X86_64_REX_GOTPCRELX issues.
I meant the following: "For x86_64 this disables R_X86_64_GOTPCRELX and R_X86_64_REX_GOTPCRELX GOT optimization." 
(it just sounds a bit more natural, but i do not insist)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113615/new/

https://reviews.llvm.org/D113615