[PATCH] D112827: [AMDGPU][GlobalISel] Fold G_FNEG above when users cannot fold mods

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 14:40:41 PST 2021


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUCombinerHelper.h:20
+
+class AMDGPUCombinerHelper {
+protected:
----------------
Would make more sense to me to inherit from CombinerHelper


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112827/new/

https://reviews.llvm.org/D112827



More information about the llvm-commits mailing list