[PATCH] D113228: [RFC][ELF] Refactor relocation processing

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D113228#3122697 <https://reviews.llvm.org/D113228#3122697>, @stefanp wrote:

> I feel like there is a lot going on in this patch. It may be easier if it was just done little by little.
> For example: `toExecRelax` is now a static function. This can be separated out into a small NFC patch where the only thing that is done is the refactoring of that one static function. 
> Also, `handleTlsRelocation` returns a slightly different value (what should be skipped vs what was processed). This can also be done as a separate mini patch.
>
> Anyway, those are my 2 cents.

Structurally it's difficult to do it piecemeal. This patch explores an alternative way handling relocations.
If we consider the current state and the exploration local optima, some changes (like moving `toExecRelax` outside) are actually strictly inferior (if we don't split handleTlsRelocations).

For minor details, some changes can be split and I've pushed such commits separately (e.g. moving isStaticLinkTimeConstant).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113228/new/

https://reviews.llvm.org/D113228