[PATCH] D113426: [DAGCombiner] add fold for vselect based on mask of signbit, part 3

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 13:53:08 PST 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:9591
+  }
   return SDValue();
 }
----------------
lebedev.ri wrote:
> Notice the symmetry, there's final 4'th pattern there: 
> `(Cond0 s> -1) ? -1 : N1 --> ~(Cond0 s>> BW-1) | N1`
> https://alive2.llvm.org/ce/z/ZefLue
... but we don't have a `hasOrNot()` hook, so only adding a comment should be fine i suppose.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113426/new/

https://reviews.llvm.org/D113426



More information about the llvm-commits mailing list