[PATCH] D112063: [lld][ELF] Add first bits to support relocation relaxations for AArch64
Matt Morehouse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 10 13:39:12 PST 2021
morehouse added inline comments.
================
Comment at: lld/ELF/Options.td:304
+def no_relaxations: F<"no-relax">,
+ HelpText<"Disable relocation relaxations">;
----------------
alexander-shaposhnikov wrote:
> MaskRay wrote:
> > peter.smith wrote:
> > > Could you add the new option to the man page in lld/docs/ld.lld.1 ? This is really easy to miss.
> > >
> > > We may need a follow up patch to make sure that it also turns off any other relaxations such as PPC and potentially RiscV.
> > >
> > > I think the option name is the right one as BFD also has the same option name.
> > In https://reviews.llvm.org/D81359?id=269281 , I wanted to name this `relax`. Maybe let me add that x86 option back? It can be used by hwasan (@morehouse).
> ok
It seems good to have the [no-]relax flags, since GNU ld has them.
But for hwasan we are leaning towards https://reviews.llvm.org/D113220, so we can enable selective relaxation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112063/new/
https://reviews.llvm.org/D112063
More information about the llvm-commits
mailing list