[PATCH] D113606: [gn build] Fix Android compiler-rt targets

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 10 13:28:54 PST 2021


pcc added inline comments.


================
Comment at: llvm/utils/gn/secondary/compiler-rt/BUILD.gn:15-22
+  if (llvm_build_AArch64) {
+    supported_toolchains +=
+        [ "//llvm/utils/gn/build/toolchain:stage2_android_aarch64" ]
+  }
+  if (llvm_build_ARM) {
+    supported_toolchains +=
+        [ "//llvm/utils/gn/build/toolchain:stage2_android_arm" ]
----------------
I think this will need to be refactored a bit because the list of supported Android toolchains has been copied into a few places (grep for `stage2_android_aarch64`). Maybe create a `supported_android_toolchains` variable and use it in those places?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113606/new/

https://reviews.llvm.org/D113606



More information about the llvm-commits mailing list